Output images are converted to square images and aspect ratio is distorted

[abidlabs]

Describe the bug

It seems that in some Spaces, the output images are forced to be squares and this distorts the width/height ratio of the image

E.g. https://twitter.com/osanseviero/status/1582823250832211968

Is there an existing issue for this?

• I have searched the existing issues

Reproduction

Space: https://huggingface.co/spaces/runwayml/stable-diffusion-inpainting

Screenshot

No response

Logs

N/A

System Info

3.6

Severity

annoying

[freddyaboulton]

Wonder if it's cause of the style on the output Image: https://huggingface.co/spaces/runwayml/stable-diffusion-inpainting/blob/main/app.py#L75

[osanseviero]

In this same space having some weird issue with the image being cut by half

[pngwn]

The bug that @abidlabs is reporting here doesn't look like a bug at all. This isn't a styling issue, the actual image is distorted.

The author of this app has not constrained the image input to a square (https://huggingface.co/spaces/runwayml/stable-diffusion-inpainting/blob/main/app.py#L66) and then resizes to a square without cropping at all, which is expected to squash the image (https://huggingface.co/spaces/runwayml/stable-diffusion-inpainting/blob/main/app.py#L38-L39).

So I think this is expected behaviour. Now, if they did constrain the image to a square, the user wouldn't actually know about it until the image is generated and parts of the mask could be cropped out, so we should definitely improve the UX of the behaviour of the shape kwarg for Image. There is already an issue for this here (relevant comment linked):

The thing that @osanseviero mentioned is a different bug relating to the way canvas sizes are calculated based upon the source image, as far as I am aware.

[pngwn]

I've confirmed this issue is an issue with user code. There are already issues for the other problems noted.