Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to FRP client download and usage #8968

Merged
merged 13 commits into from
Aug 7, 2024
Merged

Improvements to FRP client download and usage #8968

merged 13 commits into from
Aug 7, 2024

Conversation

abidlabs
Copy link
Member

@abidlabs abidlabs commented Aug 1, 2024

No description provided.

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 1, 2024

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-builds.s3.amazonaws.com/fc6b6ee578a1109656eba1660e51546d12243dfb/gradio-4.40.0-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@fc6b6ee578a1109656eba1660e51546d12243dfb#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-builds.s3.amazonaws.com/fc6b6ee578a1109656eba1660e51546d12243dfb/gradio-client-1.4.0.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Aug 1, 2024

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
gradio patch
gradio_client patch
  • Maintainers can select this checkbox to manually select packages to update.

With the following changelog entry.

Improvements to FRP client download and usage

Maintainers or the PR author can modify the PR title to modify this entry.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@abidlabs abidlabs added the v: patch A change that requires a patch release label Aug 2, 2024
@abidlabs abidlabs marked this pull request as ready for review August 2, 2024 00:53
@aliabid94
Copy link
Collaborator

aliabid94 commented Aug 6, 2024

From #8978, hash_file is no longer deterministic due to adding a random hash_seed for security reasons. Can you update this PR to hash directly for the binary checksum test or modify hash_file to optionally skip the hash_seed?

@abidlabs
Copy link
Member Author

abidlabs commented Aug 6, 2024

👍

@aliabid94
Copy link
Collaborator

Otherwise LGTM

@abidlabs abidlabs enabled auto-merge (squash) August 7, 2024 00:52
@abidlabs abidlabs merged commit 38b3682 into main Aug 7, 2024
18 checks passed
@abidlabs abidlabs deleted the frp-sec branch August 7, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v: patch A change that requires a patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants