-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gradio 5] Some bugs with elements and css #9671
Comments
The issues around custom css are expected as the dom can change between versions. But I don't think the issues around the theme variables not being applied are. cc @aliabid94 @hannahblair |
Hi @abidlabs , so my custom css is only for vertical tabs. but border width and info text colour is getting from theme and when i inspect elements in the browser i see the class applied but not with the values that ive provided in theme. |
I believe the issues above are either resolved or there are open PRs for the issues above:
|
I mean that the tabs are not stacking vertically like in the first image (behavior in gradio 4). They are not respecting the css that I applied for them to be vertical. If you run the code example that I provided in both versions of gradio you will be able to better see the problem. |
Custom css is not guaranteed to work across versions, as the class names internally may changed. Unfortunately you're going to have to rewrite the CSS to get this effect. The logic for tabs has gotten more complex since we now handle overflow situations differently, so you may not be able to get the same effect as before. |
i will update my gradio version again and test the items 1-3, if i got error again i return here. About item 4 I will try some things in the css to see if I can make the tabs work vertically, I think this could also be a native tab feature. |
@aliabid94 ive update my gradio to 5.5.0 to test, and now components are freezed, if i click on tabs nothing happens, the galleries dont show images, on previous versios of gradio 5 it was working. I dont know what happened because ive removed my theme to test, removed custom scripts and continues freezed, and dont have any errors on terminal. I did tests until 5.1.0 version is working. Testing.Gradio.mp4 |
Only item 1 i could test. Others i cant because the problem described on video above. @abidlabs after we fix this bugs i will be able to test dynamic components on gradio 5. I already have #9595 and #9207 for dynamic errors that i found. |
Describe the bug
I am facing some bugs after gradio 5, some classes of theme is not applying properly and some components is rendering buged.
1 - Block border width - line between elements in same row is not appearing, even if it setted in my theme.
2 - Info text color - the color of info text color is always black , my provided value is not working.
3 - Tab render - elements inside tab is shifted to the right. like https://github.com/gradio-app/gradio/issues/9665
4 - Also about the tabs, before in Gradio 4 I was able to use the tabs vertically and loading the elements on the right. Now they only stay fixed horizontally.
Have you searched existing issues? 🔎
Reproduction
Screenshot
-Demo running on gradio 4, expected layout:
1 - Border width
2 - Info text color
3 - Tab element alignment
4 - Vertical tabs
Logs
No response
System Info
Severity
I can work around it
The text was updated successfully, but these errors were encountered: