Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Empty dependency graph snapshot generated when state is loaded from configuration cache #98

Closed
bigdaz opened this issue Jan 9, 2024 · 0 comments
Milestone

Comments

@bigdaz
Copy link
Member

bigdaz commented Jan 9, 2024

When the Gradle project configuration is successfully loaded from the configuration-cache, no dependencies will be resolved during the build execution. In this case, an empty dependency graph snapshot will be generated.

Submitting this empty snapshot can incorrectly clear the dependency graph for a repository, resolving any security vulnerabilities!

We should either:

  1. Fail if the configuration-cache is enabled when generating a dependency graph snapshot.
  2. Generate a different Job Correlator when configuration-cache state is reused. This would prevent the empty snapshot from overwriting a previous, correct snapshot.
  3. Detect when an empty snapshot is generated due to configuration-cache reuse, and avoid submitting this snapshot (this would require a change in gradle-build-action).
@bigdaz bigdaz added this to the 1.1.0 milestone Jan 11, 2024
@bigdaz bigdaz closed this as completed in 6b22903 Jan 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant