Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] Support for Eclipse #155

Open
eximius313 opened this issue Oct 28, 2020 · 6 comments
Open

[FeatureRequest] Support for Eclipse #155

eximius313 opened this issue Oct 28, 2020 · 6 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@eximius313
Copy link

Could you please support Eclipse as well?

@JLLeitschuh
Copy link
Contributor

JLLeitschuh commented Jan 19, 2021

This is more likely to be an issue/feature against buildship.

A PR would be welcome there.

https://github.com/eclipse/buildship

@JLLeitschuh
Copy link
Contributor

I'm going to close this issue out as I don't think that there's anything we can do on our end for this. I could be wrong though. If I am wrong, please don't hesitate to open a ticket. PRs that are well tested are also welcome.

@eximius313
Copy link
Author

@JLLeitschuh , so why this plugin can support IntelliJ IDEA (https://gradle.github.io/playframework/#limitations), but not Eclipse?

@JLLeitschuh
Copy link
Contributor

I'm not actually certain. It may require writing out some eclipse configuration files. 🤔

Maybe that could be done from this plugin instead. I'll re-open this.

Are you interested in investigating and/or creating a PR for this?

@JLLeitschuh JLLeitschuh reopened this Jan 21, 2021
@JLLeitschuh JLLeitschuh added enhancement New feature or request good first issue Good for newcomers labels Jan 21, 2021
@eximius313
Copy link
Author

I could help with testing :)

@big-guy
Copy link
Member

big-guy commented Jan 22, 2021

The reason we have a separate IDEA plugin for Play is because that's what the old plugin did. The only reason the old plugin did that was because it didn't use the current model Java/Scala plugin.

Now that we're using those plugins (and not the software model ones), we should be able to configure SourceSets in the right way to avoid almost everything that's happening in PlayIdeaPlugin and Eclipse should "just work".

It's possible that Eclipse might work now. I suspect the only thing missing are the non-standard resource directories, which could be added manually to the build configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants