Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle catalog compatibility #41

Closed
elect86 opened this issue Jan 16, 2023 · 1 comment
Closed

Gradle catalog compatibility #41

elect86 opened this issue Jan 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@elect86
Copy link

elect86 commented Jan 16, 2023

Hello,

nice lib!

Anyway, I'd love this to work with the Gradle Catalog feature, ie:

extraJavaModuleInfo {
    module(libs.therapi) {
        exportAllPackages()
    }
}

All the traditional args should be easily reachable from that handle..

@jjohannes jjohannes added the enhancement New feature or request label Jan 16, 2023
@jjohannes
Copy link
Member

Thanks for the suggestion.

A complete example would have to look like the following though. The module name is still required as argument:

extraJavaModuleInfo {
    module(libs.therapi, "com.example.therapi.modulename") {
        exportAllPackages()
    }
}

In any case, the Catalog can be used right now. The syntax just doesn't look that "nice". But I don't think there is any other drawback. You can do this right now:

extraJavaModuleInfo {
    module(libs.therapi.get().module.toString(), "com.example.therapi.modulename") {
        exportAllPackages()
    }
}

I think supporting the Catalog types in the API directly could be a nice addition and a PR is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants