Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Vendor Update Tracking #112

Closed
rfratto opened this issue Jun 9, 2020 · 5 comments
Closed

Prometheus Vendor Update Tracking #112

rfratto opened this issue Jun 9, 2020 · 5 comments

Comments

@rfratto
Copy link
Member

rfratto commented Jun 9, 2020

This issue is meant to track new versions of Prometheus and decide whether they introduce new functionality that the Agent would benefit from. We will note each version as:

  • vendored in bold
  • skipped update in italics.
  • planned for vendoring in non-bold, not italicized text

The current vendored version of Prometheus is v2.21.0.

@rfratto rfratto pinned this issue Jun 9, 2020
@hardproblems
Copy link

hardproblems commented Aug 10, 2020

@rfratto is a timeline for when the next release containing prometheus updates will land? We're trying to compare the resource usage for grafana-agent and prometheus for a POC and saw a ~30% memory usage reduction between Prometheus 2.18 -> 2.19.3. Would love to be able to pull this into grafana-agent soon if possible.

@rfratto
Copy link
Member Author

rfratto commented Aug 11, 2020

@hardproblems The 0.5.0 release tomorrow won't have anything, but we should be able to update the Prometheus vendor to 2.20.1 for the 0.6.0 release. I had a quick chat with the team here and it seems like we'll be able to release 0.6.0 around the week of August 17th at the earliest or the week of August 24th at the latest.

I've opened #149 to track the progress with this.

@rfratto
Copy link
Member Author

rfratto commented Sep 4, 2020

@hardproblems Sorry, the release got pushed back a week further than I had expected. We just released v0.6.0 that includes Prometheus 2.20.1.

@rfratto
Copy link
Member Author

rfratto commented Sep 4, 2020

I'm going to lock this issue so it's purely for tracking; if anyone has a question about when we're going to update the vendor feel free to open a specific issue for the question or ask me on our public #agent slack channel at https://slack.grafana.com/.

@grafana grafana locked and limited conversation to collaborators Sep 4, 2020
@jtlisi jtlisi unpinned this issue Sep 27, 2020
@rfratto rfratto pinned this issue Oct 5, 2020
@rfratto
Copy link
Member Author

rfratto commented Nov 27, 2020

I'm closing and unpinning this. There's a lot of dependencies in the Agent that need tracking, and that number is just going to keep growing.

There's now a GitHub action that runs every day and will check for updates against an allowlist of dependencies we explicitly want to track; Prometheus is one of them. You can see the results of this action in #267. All of the issues will have the label outdated-dependency. Closing them means that we intend to not update to that version, though if anyone needs a specific feature, please let us know and we can re-open.

@rfratto rfratto closed this as completed Nov 27, 2020
@rfratto rfratto unpinned this issue Nov 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants