Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add opt in feature telemetry #1488

Closed
mattdurham opened this issue Mar 14, 2022 · 4 comments · Fixed by #1661
Closed

Add opt in feature telemetry #1488

mattdurham opened this issue Mar 14, 2022 · 4 comments · Fixed by #1661
Assignees
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness

Comments

@mattdurham
Copy link
Collaborator

Add telemetry on major feature flags being used, this will help Agent team determine if a feature is getting enough traction to graduate from experimental/beta and what users are finding helpful/useful.

Ideals:

  • Opt in only, likely via a flag
  • No identifiable information, ie no ips, usernames, ect
  • No sensitive information was sent, ie record that remote configuration is being used but not the URL
  • Configurable endpoint and easily view what is sent (add to logs?)

The initial dataset is the feature flags used, and if the scraping service is being used.

@rfratto
Copy link
Member

rfratto commented Mar 14, 2022

Agree that this would be useful for us to find out who is using what so we can make more informed development decisions, and 100% agree that it's very important for this to be opt-in. (Though I'm personally OK with it being set in the YAML so you can opt-out dynamically without having to restart)

Loki recently added usage reports in to its server too: grafana/loki#5361
Current Loki code is here: https://github.com/grafana/loki/tree/main/pkg/usagestats

@rfratto
Copy link
Member

rfratto commented Mar 14, 2022

I asked around how this works for Loki and Grafana and was told that:

  • Grafana sends the usage report every 24 hours when enabled, and Loki sends it every 4 hours when enabled. The frequency is flexible but too frequent can make it harder to do aggregations.
  • Both Loki and Grafana store a random UUID fingerprint for each instance so that usage stats from the same process can be correlated but still be anonymous and non-identifiable

@rfratto rfratto added the enhancement New feature or request label Mar 16, 2022
@github-actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had any activity in the past 30 days.
The next time this stale check runs, the stale label will be removed if there is new activity. The issue will be closed in 7 days if there is no new activity.
Thank you for your contributions!

@github-actions github-actions bot added the stale Issue/PR mark as stale due lack of activity label Apr 16, 2022
@rfratto rfratto added keepalive Never close from staleness and removed stale Issue/PR mark as stale due lack of activity labels Apr 18, 2022
@marctc
Copy link
Contributor

marctc commented May 5, 2022

Ideals:

* Opt in only, likely via a flag

We decided to change it to opt out. The reason is temporarly documented here.

@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. keepalive Never close from staleness
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants