Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow: otelcol.processor.discovery component #2299

Closed
Tracked by #2213
rfratto opened this issue Oct 3, 2022 · 0 comments · Fixed by #4615
Closed
Tracked by #2213

Flow: otelcol.processor.discovery component #2299

rfratto opened this issue Oct 3, 2022 · 0 comments · Fixed by #4615
Assignees
Labels
flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Milestone

Comments

@rfratto
Copy link
Member

rfratto commented Oct 3, 2022

Expose the Grafana Agent-specific custom promsdprocessor processor component as a Flow component called otelcol.processor.discovery.

Note that this component does not have an upstream counterpart; it was something created specifically for Grafana Agent to allow for label association with telemetry data coming from Prometheus SD.

It's likely that we won't want to use the current processor and would instead make a custom one. The current processor runs a Prometheus Service Discovery manager and spawns various SD workers to find targets. This isn't necessary for Flow; we could instead just pass it a list of discovered targets similarly like what you would do for prometheus.scrape.

@rfratto rfratto added this to the v0.30.0 milestone Oct 4, 2022
@rfratto rfratto modified the milestones: v0.30.0, v0.31.0 Jan 3, 2023
@rfratto rfratto added flow Related to Grafana Agent Flow flow/feature-parity labels Jan 19, 2023
@rfratto rfratto modified the milestones: v0.31.0, v0.32.0 Jan 30, 2023
@rfratto rfratto modified the milestones: v0.32.0, v0.33.0 Feb 28, 2023
@rfratto rfratto modified the milestones: v0.33.0, v0.34.0 Apr 26, 2023
@rfratto rfratto modified the milestones: v0.34.0, v0.36.0 Jun 12, 2023
@ptodev ptodev self-assigned this Jul 26, 2023
@ptodev ptodev linked a pull request Jul 27, 2023 that will close this issue
3 tasks
@ptodev ptodev moved this from Todo to In Progress in Grafana Agent (Public) Aug 7, 2023
@github-project-automation github-project-automation bot moved this from In Progress to Done in Grafana Agent (Public) Aug 17, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants