Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OTEL: Resource Detection Processor #4183

Closed
gouthamve opened this issue Jun 16, 2023 · 3 comments · Fixed by #5764
Closed

OTEL: Resource Detection Processor #4183

gouthamve opened this issue Jun 16, 2023 · 3 comments · Fixed by #5764
Assignees
@ptodev
Labels
enhancement New feature or request flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@gouthamve
Copy link
Member

gouthamve commented Jun 16, 2023 •
edited by richardqlam
Loading

Request

The resourcedetectionprocessor and k8sattributesprocessor are good ways to enrich the signals with common metadata and we should make sure the Agent supports it.

Use case

To help add the right metadata to the signals collected by the Agent.

#2909 related k8sattributeprocessor
@gouthamve gouthamve added enhancement New feature or request type/signals flow Related to Grafana Agent Flow labels Jun 16, 2023
@gouthamve gouthamve changed the title OTEL: Resource Detection Processor OTEL: Resource Detection Processor and k8s attributes processor Jun 16, 2023
@gouthamve
Copy link
Member Author

This is slightly different from the Prometheus SD mechanism in that it produces attributes that are aligned to the defined OpenTelemetry Semantic Conventions.

@richardqlam
Copy link

#2909 related k8sattributeprocessor

@richardqlam richardqlam changed the title OTEL: Resource Detection Processor and k8s attributes processor OTEL: Resource Detection Processor Sep 7, 2023
@rfratto rfratto added this to the v0.38.0 milestone Oct 16, 2023
@ptodev ptodev self-assigned this Oct 30, 2023
@rfratto rfratto removed this from the v0.38.0 milestone Nov 2, 2023
@ptodev ptodev linked a pull request Nov 14, 2023 that will close this issue
Add an otelcol.processor.resourcedetection component #5764
Merged
@cyrille-leclerc
Copy link

Should GA on Feb 27th

@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Mar 14, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ptodev ptodev

Labels
enhancement New feature or request flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Grafana Agent (Public)
Status: Todo
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add an otelcol.processor.resourcedetection component grafana/agent
5 participants
@cyrille-leclerc @rfratto @ptodev @gouthamve @richardqlam