Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flow: Alternative to Static mode's tracing automatic_logging processor #4261

Closed
Tracked by #2213
ptodev opened this issue Jun 26, 2023 · 0 comments · Fixed by #4713
Closed
Tracked by #2213

Flow: Alternative to Static mode's tracing automatic_logging processor #4261

ptodev opened this issue Jun 26, 2023 · 0 comments · Fixed by #4713
Assignees
Labels
flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Milestone

Comments

@ptodev
Copy link
Contributor

ptodev commented Jun 26, 2023

Request

The traces config in Static mode contains an automatic_logging processor which can create log lines from traces. This is similar to otelcol.exporter.logging, but more flexible in some ways:

  • The log output could be sent to Loki, whereas otelcol.exporter.logging can only write to console
  • automatic_logging could log a line per span, root, or process.
  • Overrides for Loki log labels

Additionally, it was reported that viewing output of otelcol.exporter.logging can be awkward since it outputs \n inside the message, which forces people to paste the message in an editor and replace the line breaks.

I am not sure how the automatic_logging processor is used by customers and how important all those features are. If we want to integrate with Loki or to have the additional filtering on span/root/process, then we could create a new component. The new component could output Otlp-formatted logs, and then this could be piped to otelcol.exporter.loki and loki.write?

This new component would be a bit like Otel's spanmetrics connector, but instead of metrics it would create logs out of the traces. AFAIK there is no such component planned for the Collector yet.

Use case

Flow feature parity.

@ptodev ptodev added type/signals flow Related to Grafana Agent Flow labels Jun 26, 2023
@ptodev ptodev self-assigned this Jul 25, 2023
@ptodev ptodev added this to the v0.36.0 milestone Jul 25, 2023
@ptodev ptodev linked a pull request Aug 4, 2023 that will close this issue
4 tasks
@github-project-automation github-project-automation bot moved this from Todo to Done in Grafana Agent (Public) Aug 25, 2023
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 21, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
flow Related to Grafana Agent Flow frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant