Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update k3d example to use k3d 4.x #452

Closed
rfratto opened this issue Mar 5, 2021 · 2 comments
Closed

Update k3d example to use k3d 4.x #452

rfratto opened this issue Mar 5, 2021 · 2 comments
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.

Comments

@rfratto
Copy link
Member

rfratto commented Mar 5, 2021

The k3d example still expects a version <3.0, and is easy to miss as a requirement. We should update the scripts to expect k3d 4.x.

k3d 4.x automatically merges the cluster into your kube config for you, so we can also remove the merge script after this upgrade, and just leave the create script.
@rfratto rfratto added the size/s label Mar 5, 2021
@hoenn
Copy link
Contributor

hoenn commented Apr 6, 2021

@rfratto I think this closed by #510

@rfratto
Copy link
Member Author

rfratto commented Apr 6, 2021

👍

@rfratto rfratto closed this as completed Apr 6, 2021
@github-actions github-actions bot added the frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed. label Feb 23, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
frozen-due-to-age Locked due to a period of inactivity. Please open new issues or PRs if more discussion is needed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rfratto @hoenn