Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: deprecate cookie field in /vcs.v1.VCSService/GithubLogin and /vcs.v1.VCSService/GithubRefresh #187

Open
alsoba13 opened this issue Sep 23, 2024 · 0 comments
Assignees

Comments

@alsoba13
Copy link
Contributor

alsoba13 commented Sep 23, 2024

Refactor cookie manager and VCS client to use new version of the API:

Changes in VCS client

/vcs.v1.VCSService/GithubLogin and /vcs.v1.VCSService/GithubRefresh now include 3 new fields. Resulting in:

  • cookie field becomes deprecated.
  • Instead, use token, token_expires_at and refresh_token_expires_at for creating the cookie.

Current cookie format is also deprecated. Backend accepts both the old and the new formats.

New cookie format

Backend expects frontend to append a cookie with the name pyroscope_git_session and the following base64 encoded json body:

  • token: the same that came in the backend response (required).
  • token_expires_at: optional
  • refresh_token_expires_at: optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants