Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The query builder does not allow to edit regex filter values in place #206

Closed
grafakus opened this issue Oct 1, 2024 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@grafakus
Copy link
Contributor

grafakus commented Oct 1, 2024

Bug description

  • Grafana version: 11.2.0
  • Plugin version: 0.1.9

Issue reported in the Grafana repository: grafana/grafana#93664

Steps to reproduce

  1. Go to a view where filters can be added, e.g. the "Flame graph" view
  2. Add a filter with a regex operator, e.g.: container =~ .+-go-.+ (url)
  3. Click on the filter value to edit it

Actual behaviour

The input does not contain the regex value, making it difficult to edit complex regular expressions:

Image

Expected behaviour

The input should contain the regex value

@grafakus grafakus added the enhancement New feature or request label Oct 1, 2024
@grafakus grafakus changed the title [bug] The query builder does not allow to edit regex filer values in place The query builder does not allow to edit regex filer values in place Oct 1, 2024
@grafakus grafakus changed the title The query builder does not allow to edit regex filer values in place The query builder does not allow to edit regex filter values in place Oct 1, 2024
@grafakus grafakus self-assigned this Oct 1, 2024
@grafakus
Copy link
Contributor Author

grafakus commented Oct 1, 2024

cc @tomershafir here's the PR to fix it #207

@grafakus grafakus added bug Something isn't working and removed bug Something isn't working labels Oct 1, 2024
@grafakus grafakus closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant