Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refreshing user token triggers OAuth login popup #44

Open
bryanhuhta opened this issue Jul 11, 2024 · 0 comments
Open

Refreshing user token triggers OAuth login popup #44

bryanhuhta opened this issue Jul 11, 2024 · 0 comments
Labels
bug Something isn't working needs refinement The issue is confirmed but it needs prioritising and a better definition of the criteria

Comments

@bryanhuhta
Copy link
Contributor

When a user token gets refreshed, the UI state will be set such that the GitHub login window will pop up. While this doesn't cause bugs that break workflows, it is nonetheless a disruptive experience and makes the product feel like malware.

We need to research specifically what state causes the popup to render and ensure a refreshing token does not trigger it. This could be a good candidate for an e2e test.
@bryanhuhta bryanhuhta added the bug Something isn't working label Jul 11, 2024
@grafakus grafakus added the needs refinement The issue is confirmed but it needs prioritising and a better definition of the criteria label Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs refinement The issue is confirmed but it needs prioritising and a better definition of the criteria
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bryanhuhta @grafakus