-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: improve page-limits handling #302
Comments
I ran into this yesterday. The project I was querying has hundreds of closed issues, so no matter what I did I only got the first bunch. It also seems the filters are applied after the query, so I couldn't work around the limit either 😞 |
Possibly related given apps have much higher rate limits compared to a user PAT. Another thing that could help is using the logged in users auth since that could scale better for concurrent users compared to using app auth |
we have some hardcoded page limits in the code, for example:
github-datasource/pkg/github/constants.go
Line 4 in 4452e59
github-datasource/pkg/github/projects/projects.go
Line 15 in 4452e59
we should increase these, but if we increase them too much we'll hit rate limits. some ideas:
(see #232 for more context)
The text was updated successfully, but these errors were encountered: