Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

selectableFields on optional fields produces wrong code #407

Closed
bcotton opened this issue Sep 13, 2024 · 0 comments · Fixed by #409
Closed

selectableFields on optional fields produces wrong code #407

bcotton opened this issue Sep 13, 2024 · 0 comments · Fixed by #409
Assignees
@IfSentient
Labels
type/bug Something isn't working

Comments

@bcotton
Copy link
Contributor

bcotton commented Sep 13, 2024

An optional string field that is field selectable generates the wrong code

Error: pkg/generated/resource/testkind/v1alpha1/testkind_schema_gen.go:23:70: cannot use cast.Spec.StringField (variable of type *string) as string value in return statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IfSentient IfSentient

Labels
type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[codegen] Fix Codegen for Optional selectableFields Values grafana/grafana-app-sdk
3 participants
@bcotton @radiohead @IfSentient