Updated the panel render wait function to account for Grafana version 6 #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Are you trying to render a full dashboard? |
|
@marefr Yes, I am rendering a full dashboard. I assumed that was what this particular function was for since it takes a count of the panels on the page and then compares that number to the number of panels that have been rendered. Am I correct in my assumption? |
marefr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using grafana-image-renderer with Grafana 6.3.3 I was getting several dashboards that were rendering with empty panels. Upon inspection of the page, I realized that there is not a '.panel' class applied to the panels any more.
I added
|| document.querySelectorAll('.panel-container').lengthto line 73 to account for this change.I have not done any rigorous testing, but it did solve my problem.
I am using grafana-image-renderer as a docker image.