Error 400 after upgrading grafana from 10.2.2 to 10.2.3

[jmhg2]

After upgrading grafana from 10.2.2 to 10.2.3, existing dashboards using zabbix-grafana plugin return error 400 in Metrics panels

When changing again to 10.2.2 the dashboards are working fine. Looking for the error it seems that the query is malformed because executing the query in the database gives an error

Software versions

Grafana	Zabbix	Grafana-Zabbix Plugin
10.2.3	6.0.14	4.4.4

[maxtymchenko]

I can confirm this reproducible on the latest version of Zabbix server 6 LTS - 6.0.25

offending queries comparison between Grafana 10.2.2 and 10.2.3 :

10.2.2 (working):

SELECT to_char(itemid, 'FM99999999999999999999') AS metric, clock / 15 * 15 AS time, AVG(value) AS value FROM history_uint WHERE itemid IN (42243) AND clock > 1704181979 AND clock < 1704203579 GROUP BY 1, 2 ORDER BY time ASC

10.2.3 (broken):

SELECT CAST(itemid AS CHAR) AS metric, clock DIV 15 * 15 AS time_sec, AVG(value) AS value FROM history_uint WHERE itemid IN (42243) AND clock > 1704179801 AND clock < 1704201401 GROUP BY clock DIV 15 * 15, metric ORDER BY time_sec ASC

PS those queries are for the same item on the same server - i.e. no changes on zabbix side

[maxtymchenko]

Further investigation shows that "Direct DB connection" setting has been emptied after upgrade onto grafana v 10.2.3

Zabbix data source cannot see any Postgres DB anymore (however can see mysql ones)

finally, grafana-zabbix is getting confused by the code grafana-zabbix-main\src\datasource\zabbix\connectors\sql\sqlConnector.ts:

loadSQLDialect() {
if (this.datasourceTypeId === supportedDatabases.postgres) {
this.sqlDialect = postgres;
} else {
this.sqlDialect = mysql;
}
}

which explains the malformed query

[maxtymchenko]

related to #1764

[daFlo]

+1

Grafana: 10.2.3
Zabbix: 6.4.10
Grafana-Zabbix Plugin: 4.4.4

[gabor]

summary of the probable cause:

• at

  grafana-zabbix/src/datasource/zabbix/connectors/sql/sqlConnector.ts

  Line 34 in dfe360b

  if (this.datasourceTypeId === supportedDatabases.postgres) {

  the code is checking if the given plugin is a postgres-plugin, by checking if it's id is postgres
• in grafana10.2.3, the id of the postgres plugin changed to grafana-postgresql-dataosource ( https://github.com/grafana/grafana/blob/d1b0e9082dce87642b3d9bd18abd9430b509c8fa/public/app/plugins/datasource/grafana-postgresql-datasource/plugin.json#L4 )

[gabor]

this seems to be duplicate of #1764 , closing this one.