Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annotations: Click links and select text from annotation popover #1588

Closed
hwangroman opened this issue Mar 12, 2015 · 24 comments
Closed

Annotations: Click links and select text from annotation popover #1588

hwangroman opened this issue Mar 12, 2015 · 24 comments

Comments

@hwangroman
Copy link

Hello,

I'm curious if links have been already implemented in annotations?
I see that it was mentioned here: #394 (comment) , but I could not find any other information regarding it.

Thanks
Roman

@torkelo
Copy link
Member

torkelo commented Mar 12, 2015

No they havent :( I would love to add this. But need to tweak the tooltip lib or exchange it to make the tooltips stick so you can hover over them.

@hwangroman
Copy link
Author

Ok, thanks for update. Will look forward for that functionality.

@mtanda
Copy link
Collaborator

mtanda commented Nov 6, 2015

+1

@einsiedlerkrebs
Copy link

hi,

first a short: "thanks for grafana"

sencondly a +1.

cause i would also love to have a clickable link in the annotations.

Thanks

@m4dc4p
Copy link

m4dc4p commented Dec 3, 2015

+1 (includes the ability to copy annotation text)

@akrus
Copy link

akrus commented Feb 8, 2016

+1

@torkelo
Copy link
Member

torkelo commented Feb 23, 2016

Finally now have much better tooltip/popover lib that can handle this scenario!

Merged to master
annotation_links

@torkelo torkelo closed this as completed Feb 23, 2016
@torkelo torkelo added this to the 3.0-beta1 milestone Feb 23, 2016
@torkelo torkelo changed the title Links in annotations? Annotations: Click links and select text from annotation popover Feb 23, 2016
@mtanda
Copy link
Collaborator

mtanda commented Feb 23, 2016

Nice work! 👍 👍 👍

@hwangroman
Copy link
Author

Awesome, thanks

@einsiedlerkrebs
Copy link

YES!. Nice thanks a lot!

@m4dc4p
Copy link

m4dc4p commented Feb 23, 2016

@torkelo Can you reference the PR containing this update?

@volter
Copy link
Contributor

volter commented Feb 24, 2016

Can you explain how the hyperlink is created?

@torkelo
Copy link
Member

torkelo commented Feb 24, 2016

Its a simple link / anchor element in the annotation description field

@volter
Copy link
Contributor

volter commented Feb 24, 2016

So, this is a place where HTML is interpreted then?

@torkelo
Copy link
Member

torkelo commented Feb 24, 2016

@volter no, that is handled by the browser

@volter
Copy link
Contributor

volter commented Feb 24, 2016

I should have said, it's not sanitized or escaped, like it was discussed for #3673.

Thank you for clarifying it!

@torkelo
Copy link
Member

torkelo commented Feb 25, 2016

It is sanitized by grafana

@deepujain
Copy link

I could not find the way to test link with Annotation on 3.0 beta 1 released during April

@torkelo
Copy link
Member

torkelo commented Apr 9, 2016

?
Try having an annotation with text containing an anchor

@chigurupati
Copy link

Hello @torkelo

I don't no how to add link with Annotations in 3.0 beta during april.

What do you mean by "annotation with text containing an anchor"? Do you mean while giving name to the annotation?

Moreover when I click on the new to create a new annotation it gives me the below error.
capture

Thanks,
Amar.

@torkelo
Copy link
Member

torkelo commented Apr 11, 2016

do you have any data sources defined? Are any of them marked as default?

@chigurupati
Copy link

yes, I do have influxdb data sources but none are set as default.

@torkelo
Copy link
Member

torkelo commented Apr 11, 2016

please set one as default, this is required (but not enforced in the UI / backend, which it should be)

@chigurupati
Copy link

ok thanks. I have set the default DS.

Now that the plugin error is cleared, where do I add the link in annotations?

capture

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

9 participants