Explore UI - updated PromQL / LogQL statement not being resolved correctly when 'Run Query' clicked

[aengusrooneygrafana]

What happened:

(Step 1) In Grafana Explore, run a PromQL or LogQL query, e.g.

Query1 - PromQL example
sum(count_over_time(container_network_transmit_errors_total{namespace="production"}[10m]))

Query2 - LogQL example
sum(count_over_time({error_level="ERROR"}[10m]))

Click 'Run Query' - the expected result is displayed.

(Step 2) Modify the query to remove the sum funciton sum( and )

Query1 modified -
count_over_time(container_network_transmit_errors_total{namespace="production"}[10m])

Query2 modified -
count_over_time({error_level="ERROR"}[10m])

Click 'Run Query' immediately after deleting the closing bracket ) - an error is returned.

Error Query 1 -

Error Query 2 -

Json Query 1 - note the 'expression' still contains the closing bracket )

{
  "state": "Error",
  "series": [],
  "annotations": [],
  "error": {
    "message": "\"invalid parameter \\\"query\\\": 1:87: parse error: unexpected right parenthesis ')'\"",
    "refId": "A",
    "status": 400,
    "statusText": ""
  },
  "request": {
    "app": "explore",
    "dashboardId": 0,
    "timezone": "browser",
    "startTime": 1626953875815,
    "interval": "2s",
    "intervalMs": 2000,
    "panelId": "Q-5831a900-a26c-4e9b-8383-1e4ed1d05c37-0",
    "targets": [
      {
        "refId": "A",
        "key": "Q-5831a900-a26c-4e9b-8383-1e4ed1d05c37-0",
        "exemplar": true,
        "expr": "count_over_time(container_network_transmit_errors_total{namespace=\"production\"}[10m]))"
      }

Json Query 2 - note the 'expression' still contains the closing bracket )

{
  "state": "Error",
  "series": [],
  "request": {
    "app": "explore",
    "dashboardId": 0,
    "timezone": "browser",
    "startTime": 1626953406049,
    "interval": "2s",
    "intervalMs": 2000,
    "panelId": "Q-f912cbf1-f83e-4741-be69-c0ba1427eadf-0",
    "targets": [
      {
        "refId": "A",
        "key": "Q-f912cbf1-f83e-4741-be69-c0ba1427eadf-0",
        "expr": "count_over_time({error_level=\"ERROR\"}[10m]))"
      }

What you expected to happen:

No error returned after clicking on 'Run Query'

How to reproduce it (as minimally and precisely as possible):

Follow the steps above

Anything else we need to know?:

n/a

Environment:

• Grafana version: Grafana Cloud Hosted Grafana 8.0.6
• Data source type & version: Grafana Cloud Hosted Prometheus and Hosted Loki
• OS Grafana is installed on: Grafana Cloud
• User OS & Browser: MacOS & Chrome
• Grafana plugins: n/a
• Others: n/a

[aengusrooneygrafana]

Additional note:

"Click 'Run Query' immediately after deleting the closing bracket ) - an error is returned"

You need to hit 'Run Query' very quickly after deleting the closing bracket to reproduce this, in under a second.

[ifrost]

Could be related to the way we debounce running the query. One solution could be to cancel debouncing onBlur(). I had similar issues reported in the past. cc @gabor @davkal

[ifrost]

Possibly related to grafana/x-ray-datasource#24 and #33319

[gabor]

@ifrost yes it does sound like an issue with the debounce (though i did not debug the code to verify it). i think in general what we want is:

• the data-model is updated immediately without debounce (technically this means on every keypress)
  • (this might be technically challenging/impossible in some cases though)
• (in panel, not explore) trigger query re-evaluation in a debounced way

your idea with not-debouncing onblur sounds reasonable, though i wonder if it could cause problems in some corner cases

@ivanahuckova any ideas?

[github-actions]

This issue has been automatically marked as stale because it has not had activity in the last year. It will be closed in 30 days if no further activity occurs. Please feel free to leave a comment if you believe the issue is still relevant. Thank you for your contributions!

[ivanahuckova]

Since the last message, we have significantly change the code and switched query editor library. Moreover, I was not able to reproduce this anymore. So closing the issue.