Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus: Incremental querying option for to: now dashboards #62932

Merged
merged 149 commits into from
Apr 12, 2023

Conversation

leeoniya
Copy link
Contributor

@leeoniya leeoniya commented Feb 6, 2023

This PR introduces incremental querying to the Prometheus data source.
Design doc
Spec sheet

Incremental querying is being used to refer to a caching/amending concept that can help unify partial queries for Prometheus and Loki (#62767) that works for exemplars as well. This hasn't yet been applied to annotations in this PR, but should also work.

In other words, this makes subsequent dashboard queries much smaller, as we're only querying the duration between each refresh, plus any additional overlap that the user has specified (defaults to 10 minutes).

This PR introduces data source configuration fields that default off, so users will need to opt-in data sources to use this feature, which should be considered in beta.

@itsmylife
Copy link
Contributor

@gtk-grafana requestId was removed intentionally. See https://github.com/grafana/grafana/pull/63913/files#diff-df1f62e68ea660d4a9d411e360d9d3cc554bd877b990ebd8684404d01c0504da

Copy link
Contributor

@itsmylife itsmylife left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀
Thanks for the amazing work! @gtk-grafana @leeoniya

@gtk-grafana gtk-grafana modified the milestones: 9.5.0, 10.0.0 Apr 3, 2023
gtk-grafana and others added 2 commits April 3, 2023 13:21
@leeoniya leeoniya changed the title Prometheus: Incremental querying Prometheus: Incremental querying option for to: now dashboards Apr 11, 2023
Copy link
Contributor

@gtk-grafana gtk-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, great work everybody!

@gtk-grafana gtk-grafana merged commit 2b2a4e1 into main Apr 12, 2023
@gtk-grafana gtk-grafana deleted the leeoniya/prom-incr-query branch April 12, 2023 18:10
@zerok zerok modified the milestones: 10.0.0, 10.0.0-preview May 31, 2023
@nemobis
Copy link
Contributor

nemobis commented Jul 21, 2023

Design doc
Spec sheet

Is there a public version of these documents? Ideally, please attach an ODT copy here. Thanks! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/backend area/frontend datasource/Prometheus no-backport Skip backport of PR type/docs Flags the technical writing team for documentation support; auto adds to org-wide docs project
Projects
None yet
Development

Successfully merging this pull request may close these issues.