LibraryPanels: Don't include ScopedVars with persisted model #67843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaydelaney
added
type/bug
area/frontend
add to changelog
breaking change
kaydelaney
requested review from
tskarhed,
eledobleefe,
a team,
axelavargas,
polibb and
torkelo
and removed request for
a team
|
@dprokop suggested adding a release note if we're potentially breaking the behavior of the app. Double checking if this is a real breaking change. |
|
I played around with both cases: the bug and the solution. It seems to me that we'd be introducing a bug in place of another bug. Now instead of having this problem: Screen.Recording.2023-05-11.at.10.20.01.movWe'd have this problem: Screen.Recording.2023-05-11.at.10.17.08.movI don't think it's that much better. |
|
@polibb How about with the last commit? |
torkelo
reviewed
May 11, 2023
| @@ -64,7 +64,7 @@ export async function getLibraryPanel(uid: string, isHandled = false): Promise<L | |||
| schemaVersion: 35, // should be saved in the library panel | |||
| panels: [result.model], | |||
| }); | |||
| const model = dash.panels[0].getSaveModel(); // migrated panel | |||
| const { scopedVars, ...model } = dash.panels[0].getSaveModel(); // migrated panel | |||
There was a problem hiding this comment.
getSaveModel should never include scopedVars, it should be safe to add scopedVars to non persisted props in PanelModel?
It is cleaned as part of DashboardModel.getPanelSaveModels but maybe it's better to do that in PanelModel ?
ivanortegaalba
added
no-changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ScopedVars from library panel before saving.
Unfortunately this highlights another issue in that repeats are processed before library panels are resolved, so if a library panel is repeated by a variable, that variable's value needs to be refreshed or changed for repeats to be processed.
I think it's possible this is a regression introduced during the library panel frontend move, but I'd have to investigate.
Closes #65518
Note: I've marked this as a breaking change since I guess it's possible someone somewhere depended on this behavior.