Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugins: Bump Plugin SDK version and address instance management breaking changes #68900

Merged
merged 2 commits into from
May 24, 2023
Merged

Plugins: Bump Plugin SDK version and address instance management breaking changes #68900

merged 2 commits into from
May 24, 2023

Conversation

wbrowne
Copy link
Member

@wbrowne wbrowne commented May 23, 2023

What is this feature?
Bumps grafana-plugin-go-sdk from 0.160.0 to 0.162.0 and addressed the breaking changes listed here

The changes are simply propagating context.Context from core plugin handlers to the plugin instance manager calls.

Why do we need this feature?
0.162.0 has important changes that are better to address sooner rather than later

Who is this feature for?

Grafana plugin developers

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@wbrowne wbrowne added this to the 10.1.x milestone May 23, 2023
@wbrowne wbrowne self-assigned this May 23, 2023
@wbrowne wbrowne requested a review from a team May 23, 2023 14:56
@wbrowne wbrowne requested review from a team as code owners May 23, 2023 14:56
@wbrowne wbrowne requested review from codeincarnate, mdvictor, asimpson, bossinc, idastambuk, kevinwcyu, sakjur, papagian, suntala and a team and removed request for a team May 23, 2023 14:56
@wbrowne wbrowne requested review from andresmgot and xnyo and removed request for a team May 23, 2023 14:57
@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023 •
edited
Loading

Backend code coverage report for PR #68900

Plugin Main PR Difference
azuremonitor 70.8% 70.8% 0%
cloud-monitoring 68.3% 68.3% 0%
cloudwatch 82.2% 82.2% 0%

@github-actions
Copy link
Contributor

Frontend code coverage report for PR #68900
No changes

aangelisc
aangelisc approved these changes May 23, 2023
View reviewed changes
Copy link
Contributor

@aangelisc aangelisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Azure

@wbrowne wbrowne merged commit 286b9e0 into main May 24, 2023
@wbrowne wbrowne deleted the sdk-0.162.0-ctx branch May 24, 2023 08:19
@ricky-undeadcoders ricky-undeadcoders modified the milestones: 10.1.x, 10.1.0 Aug 1, 2023
@chenrui333 chenrui333 mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aangelisc aangelisc aangelisc approved these changes

@andresmgot andresmgot andresmgot approved these changes

@asimpson asimpson asimpson approved these changes

@codeincarnate codeincarnate Awaiting requested review from codeincarnate

@mdvictor mdvictor Awaiting requested review from mdvictor

@bossinc bossinc Awaiting requested review from bossinc bossinc is a code owner automatically assigned from grafana/partner-datasources

@idastambuk idastambuk Awaiting requested review from idastambuk idastambuk is a code owner automatically assigned from grafana/aws-datasources

@kevinwcyu kevinwcyu Awaiting requested review from kevinwcyu kevinwcyu is a code owner automatically assigned from grafana/aws-datasources

@sakjur sakjur Awaiting requested review from sakjur sakjur was automatically assigned from grafana/backend-platform

@papagian papagian Awaiting requested review from papagian papagian was automatically assigned from grafana/backend-platform

@suntala suntala Awaiting requested review from suntala suntala was automatically assigned from grafana/backend-platform

@xnyo xnyo Awaiting requested review from xnyo xnyo was automatically assigned from grafana/plugins-platform-backend

Assignees

@wbrowne wbrowne

Labels
add to changelog area/backend/plugins area/backend area/plugins datasource/Azure Azure Monitor Datasource datasource/CloudWatch datasource/Elasticsearch datasource/GoogleCloudMonitoring datasource/Graphite datasource/Loki datasource/MSSQL Microsoft SQL Server Data Source datasource/MySQL datasource/OpenTSDB datasource/Postgres datasource/Prometheus datasource/Tempo dependencies Pull requests that update a dependency file no-backport Skip backport of PR type/chore
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
10.1.0
Development

Successfully merging this pull request may close these issues.
6 participants
@wbrowne @asimpson @andresmgot @aangelisc @ricky-undeadcoders @grafanabot