[v10.0.x] TimeSeries: Fix zoom not working after editing panel #72224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![grafana-delivery-bot[bot]](https://avatars.githubusercontent.com/in/329617?s=60&v=4){kind=small}
Co-authored-by: nmarrs <nathanielmarrs@gmail.com> (cherry picked from commit 425c92a)
grafana-delivery-bot
bot
added
add to changelog
area/frontend
area/panel/timeseries
nmarrs
approved these changes
Jul 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 425c92a from #72163
Fixes #71976
honestly, i'm not sure why this fixes it 😅 , but less
useEffectis always better.@nmarrs and i looked at this but unfortunately were not able to figure out why we're still accumulating an additional
setSelecthook call after every exit from panel edit. there's probably a memory leak somewhere and we only got as far as verifying that it only happens with components based on GraphNG, but not those using UPlotChart directly. not sure if it's worth investigating further since we want to get rid of GraphNG eventually, but should still keep an eye out for this issue in case it re-surfaces in the future.