Alerting: Paginate silences table(s) #74041
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
added
area/alerting
gillesdemey
requested review from
VikaCep,
konrad147 and
soniaAguilarPeiron
and removed request for
a team
gillesdemey
commented
Aug 29, 2023
| @@ -122,6 +122,7 @@ function SilenceList({ | |||
| if (!!items.length) { | |||
| return ( | |||
| <DynamicTable | |||
| pagination={{ itemsPerPage: 25 }} | |||
There was a problem hiding this comment.
This component is used by both the expired and non-expired silences
VikaCep
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
This PR adds pagination to the silences tables for active and expired silences. This prevents the UI from crashing if (tens of) thousands of silences are rendered in the UI.