Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboards: Add template variables to selectable options #75870

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

fabrizio-grafana
Copy link
Contributor

@fabrizio-grafana fabrizio-grafana commented Oct 3, 2023

Add template variables to the options of Select fields for the Search tab for the Tempo datasource. Example:
Screenshot 2023-10-03 at 13 07 51

Fixes #74210

@fabrizio-grafana fabrizio-grafana self-assigned this Oct 3, 2023
@grafana-delivery-bot grafana-delivery-bot bot added this to the 10.2.x milestone Oct 3, 2023
@fabrizio-grafana fabrizio-grafana changed the title Add template variables to selectable options Dashboards: Add template variables to selectable options Oct 3, 2023
@fabrizio-grafana fabrizio-grafana marked this pull request as ready for review October 3, 2023 09:35
@fabrizio-grafana fabrizio-grafana requested a review from a team as a code owner October 3, 2023 09:35
Copy link
Contributor

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall feel like this a solid improvement 👍

Tag values would show No options found until the user had selected a tag key. I like that approach as the users knows that the values map to the key selected. Here we are pre-populating the values with the template variables. Perhaps it would improve UX to only show the template variables in the tag values when a tag key is selected? I'm not overly convinced of this approach but am not thinking of another this minute!

Screenshot 2023-10-05 at 13 38 07

@joey-grafana
Copy link
Contributor

Improvements look good 👍 You may be working on this, what do you think about my comment regarding No options found?

@fabrizio-grafana
Copy link
Contributor Author

Yeah I wanted to have another thought on that today, because I also don't have a strong opinion on whether to keep the No options found entry until a scope is selected, or to already show the template variables.

Copy link
Contributor

@joey-grafana joey-grafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'd say it's not a necessary change to make right now.

@fabrizio-grafana fabrizio-grafana merged commit b2ba28a into main Oct 6, 2023
10 checks passed
@fabrizio-grafana fabrizio-grafana deleted the tempo/normalize-select-options branch October 6, 2023 14:32
@zerok zerok modified the milestones: 10.2.x, 10.2.0 Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request - Tempo] Dashboard Variable Consistency
4 participants