-
Notifications
You must be signed in to change notification settings - Fork 12.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Table: Cell inspector auto-detecting JSON #81152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grafana-pr-automation
bot
requested review from
a team and
Ukochka
and removed request for
a team
January 24, 2024 13:51
gtk-grafana
requested review from
codeincarnate,
drew08t and
leeoniya
and removed request for
a team
January 24, 2024 14:17
This was referenced Jan 24, 2024
gtk-grafana
changed the title
Table: Inspector auto-detect JSON
Table: Cell inspector auto-detecting JSON
Jan 24, 2024
gtk-grafana
commented
Jan 24, 2024
packages/grafana-ui/src/components/Table/TableCellInspectModal.tsx
Outdated
Show resolved
Hide resolved
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
January 24, 2024 15:16
svennergr
reviewed
Jan 24, 2024
packages/grafana-ui/src/components/Table/TableCellInspectModal.tsx
Outdated
Show resolved
Hide resolved
grafana-pr-automation
bot
requested review from
a team
and removed request for
a team
January 24, 2024 16:07
ryantxu
approved these changes
Jan 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much better -- happy we avoid trying to read every cell as json 😜
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Automatically setting the inspect type to json if the value can be parsed as JSON. This will automatically show the JSON/code view when the user clicks on the inspect icon within a table cell.
Why do we need this feature?
It's hard to read JSON without any formatting.
#79589
Who is this feature for?
Table users, specifically logs table in explore.
Which issue(s) does this PR fix?:
Fixes #79589
Special notes for your reviewer:
Please check that: