Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerting: Fix child provisioned polices not being rendered as provisioned #81449

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

soniaAguilarPeiron
Copy link
Member

What is this feature?

This PR fixes child provisioned policies not being rendered as provisioned in the policies view.

Why do we need this feature?

Provisioned policies should be rendered as provisioned (and not editable as a consequence).

Who is this feature for?

All users.

Special notes for your reviewer:

Before the fix:

Screenshot 2024-01-29 at 09 56 31

After the fix:

Screenshot 2024-01-29 at 10 28 38

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@soniaAguilarPeiron soniaAguilarPeiron added this to the 10.4.x milestone Jan 29, 2024
@soniaAguilarPeiron soniaAguilarPeiron self-assigned this Jan 29, 2024
@soniaAguilarPeiron soniaAguilarPeiron requested a review from a team as a code owner January 29, 2024 09:29
@soniaAguilarPeiron soniaAguilarPeiron requested review from gillesdemey and konrad147 and removed request for a team January 29, 2024 09:29
Copy link
Contributor

@konrad147 konrad147 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@soniaAguilarPeiron soniaAguilarPeiron merged commit 2e1229b into main Jan 29, 2024
25 checks passed
@soniaAguilarPeiron soniaAguilarPeiron deleted the alerting/fix-provisioned-policies branch January 29, 2024 09:51
@aangelisc aangelisc modified the milestones: 10.4.x, 10.4.0 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants