Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch: Remove "transparent" prop #83705

Merged
merged 4 commits into from
Mar 12, 2024
Merged

Switch: Remove "transparent" prop #83705

merged 4 commits into from
Mar 12, 2024

Conversation

Clarity-89
Copy link
Contributor

What is this feature?

The Switch component has a transparent prop, which only works for the InlineSwitch. This PR moves that prop to only apply to InlineSwitch.

@Clarity-89 Clarity-89 added no-backport Skip backport of PR no-changelog Skip including change in changelog/release notes labels Feb 29, 2024
@Clarity-89 Clarity-89 added this to the 11.0.x milestone Feb 29, 2024
@Clarity-89 Clarity-89 self-assigned this Feb 29, 2024
@Clarity-89 Clarity-89 requested review from a team as code owners February 29, 2024 14:51
@Clarity-89 Clarity-89 requested review from tskarhed and ashharrison90 and removed request for a team February 29, 2024 14:51
Copy link
Contributor

@JoaoSilvaGrafana JoaoSilvaGrafana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

Curious how come this isn't being flagged as a possible breaking change? Do you know?

@Clarity-89
Copy link
Contributor Author

👏

Curious how come this isn't being flagged as a possible breaking change? Do you know?

Good question, maybe something to do about type declarations being in the same file? I'll add the label manually just in case.

@Clarity-89 Clarity-89 added add to changelog breaking change Relevant for changelog generation and removed no-changelog Skip including change in changelog/release notes labels Mar 12, 2024
@Clarity-89 Clarity-89 merged commit 59fed92 into main Mar 12, 2024
22 checks passed
@Clarity-89 Clarity-89 deleted the switch/remove-transparent branch March 12, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
add to changelog area/frontend breaking change Relevant for changelog generation no-backport Skip backport of PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants