Alerting: Implement correct RBAC checks for creating new notification templates #83767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gillesdemey
requested review from
konrad147 and
soniaAguilarPeiron
and removed request for
a team
konrad147
reviewed
Mar 1, 2024
| <LinkButton icon="plus" variant="primary" href="/alerting/notifications/templates/new"> | ||
| Add notification template | ||
| </LinkButton> | ||
| {createTemplateSupported && ( |
There was a problem hiding this comment.
No need to check createTemplateAllowed too?
There was a problem hiding this comment.
The logic that we're applying to all of the buttons are:
- hide when not supported
- disable when user doesn't have sufficient permissions
Perhaps we should add some rationale to the button for why it's disabled in the future but I felt like hiding the actions when you don't have sufficient permissions might be confusing when the docs may reference these buttons / tabs / actions.
There was a problem hiding this comment.
Ah, I didn't noticed the disabled prop!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this feature?
Prior to this PR the button to add a new notification template was always shown regardless of wether it was supported for the current Alertmanager context or if the user has permissions to do so.
Changes in this PR bring the behaviour in line with the rest of the buttons; hiding it when not supported for the Alertmanager in context and disabling the action for users without sufficient permissions.