Elasticsearch: Queries no longer executed while typing #87652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Even if this implementation doesn't fully work, the fix is around this code and doesn't look too complex. |
matyax
force-pushed
the
matyax/elastic-dont-run-query
branch
from
0ea1176 to
1bc5b81
Compare
matyax
commented
May 16, 2024
| onChange(query); | ||
| onRunQuery(); | ||
| if (query.query === prevQuery.query || prevQuery.query === undefined) { |
There was a problem hiding this comment.
Anecdotically, running the query when it was previously undefined was required to make a test case pass, which was the correct implementation. This highlights again how important is to have quality unit tests, not only to prevent regressions, but to allow for refactors that don't break functionality.
matyax
changed the title
matyax
added
no-changelog
matyax
force-pushed
the
matyax/elastic-dont-run-query
branch
from
7f1b2be to
11bb5e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change, the query is no longer immediately run while it's being typed. This was a simple way, without a bigger impact, to achieve this result.
Which issue(s) does this PR fix?:
Fixes #79463
Special notes for your reviewer:
Please check that:
Demo:
Demo.mov