Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloudwatch: Update AWS DynamoDB Metrics #88418

Conversation

LeonardoBoleli
Copy link
Contributor

@LeonardoBoleli LeonardoBoleli commented May 29, 2024

What is this feature?

[Add a brief description of what the feature or update does.]

Why do we need this feature?

[Add a description of the problem the feature is trying to solve.]

Who is this feature for?

[Add information on what kind of user the feature is for.]

Which issue(s) does this PR fix?:

Fixes #

Special notes for your reviewer:

Please check that:

  • It works as expected from a user's perspective.
  • If this is a pre-GA feature, it is behind a feature toggle.
  • The docs are updated, and if this is a notable improvement, it's added to our What's New doc.

@LeonardoBoleli LeonardoBoleli requested a review from a team as a code owner May 29, 2024 11:42
@LeonardoBoleli LeonardoBoleli requested review from kevinwcyu and njvrzm and removed request for a team May 29, 2024 11:42
Copy link
Contributor

@njvrzm njvrzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small change request.

pkg/tsdb/cloudwatch/constants/metrics.go Outdated Show resolved Hide resolved
@njvrzm
Copy link
Contributor

njvrzm commented May 31, 2024

Hi @LeonardoBoleli, and thanks for your contribution! I've requested one minor change. Also if you could add a little bit of information to the pull request for the record that would be great.

@LeonardoBoleli LeonardoBoleli changed the title Leonardoboleli/cloudwatch/add aws/dynamodb metrics Update AWS DynamoDB Metrics Jun 3, 2024
@iwysiu iwysiu changed the title Update AWS DynamoDB Metrics Cloudwatch: Update AWS DynamoDB Metrics Jun 4, 2024
@iwysiu iwysiu added this to the 11.1.x milestone Jun 4, 2024
@iwysiu iwysiu added the no-backport Skip backport of PR label Jun 4, 2024
Copy link
Contributor

@iwysiu iwysiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pr!

link to aws docs:

Copy link
Contributor

@njvrzm njvrzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@iwysiu iwysiu merged commit d83818f into grafana:main Jun 4, 2024
36 checks passed
@kevinwcyu kevinwcyu modified the milestones: 11.1.x, 11.1.0 Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants