Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missed "datasource: null," parameter in panelDefaults for table panel #5999

Closed
beaverdude opened this issue Sep 9, 2016 · 1 comment
Closed
Milestone

Comments

@beaverdude
Copy link

  • I'm submitting a ...
  • [ x ] Bug report

when switching from default (graphite) datasource to Mixed datasource in Table panel - it throws an error.
Plugin componnet error Object {message: "Failed to find exported plugin component for query-ctrl-mixed"}
after switching back to default (graphite) and then back to Mixed - error doesn't appear.

root cause of this behavior is in
commit 16dbf31
missed "datasource: null," parameter in panelDefaults for table panel (public/app/plugins/panel/table/module.ts)
while
setDatasource(datasource) function in public/app/features/panel/metrics_panel_ctrl.ts
checks that
... target.datasource = this.panel.datasource; if (target.datasource === null) {...
this property must be null (but it is "undefined" because of missed in panelDefaults ).

@torkelo torkelo added this to the 4.0.0-Beta1 milestone Sep 10, 2016
@torkelo
Copy link
Member

torkelo commented Sep 10, 2016

thanks for reporting this! fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants