Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrading the version of controller-gen used by k6-operator #273

Closed
bm1216 opened this issue Aug 21, 2023 · 0 comments · Fixed by #325
Closed

Upgrading the version of controller-gen used by k6-operator #273

bm1216 opened this issue Aug 21, 2023 · 0 comments · Fixed by #325
Assignees
Milestone

Comments

@bm1216
Copy link

bm1216 commented Aug 21, 2023

Feature Description

TO-DO

Update the version of controller-gen supported by k6-operator.

WHY?

k6-operator is currently supporting v0.3.0 of the controller-gen cli while v0.13.0 has been released.
https://github.com/kubernetes-sigs/controller-tools/releases/tag/v0.13.0

Currently, k6-operator doesn't work with version v0.7.0 and above of controller-gen. This is due to addition of the trivialVersions option here -

CRD_OPTIONS ?= "crd:trivialVersions=true,crdVersions=v1,maxDescLen=0"

which has been removed here in controller-gen -
kubernetes-sigs/controller-tools@09f1952#diff-fa737e39d27a85a80d2b211933392436e0e10b850c68cb53e3e8873b83d82071L42-L61

Suggested Solution (optional)

No response

Already existing or connected issues / PRs (optional)

No response

@bm1216 bm1216 added the enhancement New feature or request label Aug 21, 2023
@yorugac yorugac added maintenance and removed enhancement New feature or request labels Aug 22, 2023
@yorugac yorugac self-assigned this Sep 25, 2023
@yorugac yorugac added this to the 0.12 milestone Oct 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants