Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address eslint issues that currently ignored #277

Open
e-fisher opened this issue Oct 25, 2024 · 0 comments
Open

Address eslint issues that currently ignored #277

e-fisher opened this issue Oct 25, 2024 · 0 comments
Assignees

Comments

@e-fisher
Copy link
Collaborator

e-fisher commented Oct 25, 2024

Step 1 - Done ✅

Currently, we are not using the correct config for type checked project, which allows implicit any and other type-unsafe operations. To fix this:

  1. Use plugin:@typescript-eslint/recommended-type-checked eslint config instead of plugin:@typescript-eslint/recommended https://typescript-eslint.io/getting-started/typed-linting/

  2. Fix type errors - as of writing, it shows 167 errors.

This is needed to prevent hard to find bugs in the future and keep the project type-safe.

Step 2 - TODO

Fix Eslint errors that are currently ignored. Most of them can be find under the following comment:

// TODO: https://github.com/grafana/k6-studio/issues/277
@going-confetti going-confetti self-assigned this Dec 17, 2024
@going-confetti going-confetti changed the title Update eslint to use recommended-type-checked config and fix type errors Address eslint issues that currently ignored Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants