-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor the module structure for the new executors #1302
Comments
Some of the tests of the API (and probably other modules as well) are currently structured in such a way that they import the This would cause any library that also imports them to include things like goja and core.js, which is probably not what we want... 🤦♂️ We can instead use different package names for these tests, for example |
hm ... I think that it probably won't require the |
We have recently discussed this issue in our backlog grooming session. We agreed that if the specific issue reported here: the I just verified on |
This discussion is a nice starting point for what's currently suboptimal: #1007 (comment)
I also noticed that the
lib
package depends on thejs/compiler
package...go list -f '{{ join .Imports "\n" }}' github.com/loadimpact/k6/lib | sort
produces:it's not related to the new executors, but this shouldn't be the case
The text was updated successfully, but these errors were encountered: