Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/rename lib.ExecutionTuple #1379

Closed
mstoykov opened this issue Apr 1, 2020 · 2 comments
Closed

Refactor/rename lib.ExecutionTuple #1379

mstoykov opened this issue Apr 1, 2020 · 2 comments
Labels
executors lower prio refactor
Milestone
v0.27.0

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Apr 1, 2020 •
edited
Loading

The name is ... not very helpful but is a lot shorted then lib.ExecutionSegmentAndSequence, which I would argue is nearly as useless as a description 🤣
I would argue some additional refactor can be done once it has been used everywhere it needs to be and we know what the actual use cases for it are ...
The same goes for the lib.sortInterfaceWrapper
@mstoykov mstoykov mentioned this issue Apr 1, 2020
Merged
@na--
Copy link
Member

na-- commented Apr 28, 2020

Something else we should look into is refactoring the segmented iteration from #1392 into its own thing, probably somewhat connected to the execution tuple, so we can reuse it for striped iteration over data arrays/streams.

@na-- na-- mentioned this issue May 12, 2020
Merged
@mstoykov
Copy link
Contributor Author

I am closing this as things have changed and I consider this done

@mstoykov mstoykov added this to the v0.27.0 milestone Jun 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
executors lower prio refactor
Projects
None yet
Milestone
v0.27.0
Development

No branches or pull requests
2 participants
@mstoykov @na--