Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More robust integration tests #342

Closed
StephenRadachy opened this issue Oct 19, 2017 · 1 comment · Fixed by #2412
Closed

More robust integration tests #342

StephenRadachy opened this issue Oct 19, 2017 · 1 comment · Fixed by #2412
Labels
ci good first issue help wanted tests
Milestone
v0.38.0

Comments

@StephenRadachy
Copy link
Contributor

Integration tests should be added that leverage the existing sample files - so we're not just checking that the cli can write to stdout.
@liclac
Copy link
Contributor

liclac commented Dec 10, 2017

Some integration tests are ran as a part of the js test suite, but I'd definitely welcome this. It'd be best done as a target in the Makefile, I think.

@na-- na-- added the ci label Sep 14, 2018
@na-- na-- mentioned this issue Dec 16, 2019
Merged
@na-- na-- mentioned this issue Feb 25, 2021
Closed
@na-- na-- mentioned this issue Mar 5, 2021
Merged
@na-- na-- mentioned this issue May 18, 2021
Merged
@na-- na-- added this to the v0.38.0 milestone Mar 7, 2022
@na-- na-- mentioned this issue Mar 7, 2022
Merged
@na-- na-- linked a pull request Mar 7, 2022 that will close this issue
More cmd/ refactoring to simplify test loading and support integration tests #2412
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ci good first issue help wanted tests
Projects
None yet
Milestone
v0.38.0
Development

Successfully merging a pull request may close this issue.

More cmd/ refactoring to simplify test loading and support integration tests grafana/k6
4 participants
@liclac @robingustafsson @na-- @StephenRadachy