Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: update helm chart to support distributed mode and 3.0 #12067

Merged
merged 76 commits into from
Apr 8, 2024
Merged

feat!: update helm chart to support distributed mode and 3.0 #12067

merged 76 commits into from
Apr 8, 2024

Conversation

slim-bean
Copy link
Collaborator

@slim-bean slim-bean commented Feb 27, 2024 •
edited
Loading

TODO

  • fix toplogy spread constraints in zone aware
  • fix SSD to to handle zone aware migration (honor not writing to "default-zone")
  • distributor also needs to have config for not writing "default-zone"
  • replica count for zone aware needs to be a divide by 3
  • add rollout operator
  • add memcached
  • make sure configmap isn't a secret (or make configurable)
  • verify query-scheduler and query-frontend addresses are set correctly in distributed
  • add configs to persist tokens and not unregister on shutdown
  • add mutating webhook and labels so rollout operator can control scaledown

trevorwhitney and others added 10 commits January 31, 2024 10:39
@trevorwhitney
feat: add distributed mode to loki helm chart
df50d2f
@DylanGuedes
Helm: Fix http port name (#11846)
a0011b9 
**What this PR does / why we need it**:
Components were expecting the port name to be `http` instead of
`http-metrics`.

**Which issue(s) this PR fixes**:
N/A
@DylanGuedes
Helm: Add distributed URLs to nginx gateway (#11853)
b512bfb 
**What this PR does / why we need it**:
Modify our nginx proxy pass to redirect to microservices components
correctly.
Modify index-gateway to run in simple mode by default.
Fix distributor svc target port (http-metrics instead of `http`).

**Which issue(s) this PR fixes**:
N/A
@DylanGuedes
Helm: Fix chart mTLS implementation (#12025)
3f5f69e
@DylanGuedes
cleanup TLS defintions
5d54647
@DylanGuedes
add comment
6ebc613
@slim-bean
updates canary tests to use direct push and directy querying of canar…
da0387a 
…ies to remove dependencies on agent and prometheus. Disables self monitoring by default.

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
reordering and reorganizing values.yaml
82873ea 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
move canary configs to top level
a2bbd97 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
update ci and include a values file for testing the legacy included m…
02b7a7b 
…onitoring

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@github-actions github-actions bot added area/helm type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Feb 27, 2024
@slim-bean
help debug tests by adding stdout to logs
488bbf8 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
remove "Deployment" kind for ingester, can only be statefulset.
f1fc779 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
remove "Deployment" kind for compactor, can only be statefulset.
ce6ccd3 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
remove "Deployment" kind for ruler, can only be statefulset.
289c74c 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
introduce the idea of a chart mode
a5ddb10 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
remove the 'enabled' variable from the compactor, index-gateway, quer…
e512338 
…ier, query-scheduler, and ruler

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean force-pushed the ewelch-distributed-helm-chart branch from b658b43 to e512338 Compare February 28, 2024 00:51
slim-bean added 9 commits March 1, 2024 00:18
@slim-bean
fix the deployment modes and validations
40bb084 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
remove string templating of toplogySpreadConstraints and podAffinity …
6140657 
…rules. Remove soft constraint on zone

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
fix the failing config_test where it needed the charts dependencies i…
c4d44ea 
…nstalled.

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
first pass at zone awareness
5e27c1f 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
second pass at zone awareness
86888d4 
adding rollout operator
persisting tokens
setting replica counts and max unavailable

Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
fix headless service name
d288491 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
add enterprise gateway
b5cadab 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
only deploy enterprise gateway when enterprise is enabled
d88877e 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean
add admin api
7fa517d 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
@slim-bean slim-bean force-pushed the ewelch-distributed-helm-chart branch from 1403139 to 7fa517d Compare March 5, 2024 23:39
grafanabot pushed a commit that referenced this pull request Apr 8, 2024
@slim-bean @grafana-delivery-bot
feat!: update helm chart to support distributed mode and 3.0 (#12067)
7b0fb4c 
Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
(cherry picked from commit 79b876b)
@grafanabot grafanabot mentioned this pull request Apr 8, 2024
Merged
10 tasks
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 8, 2024
Closed
@AllexVeldman AllexVeldman mentioned this pull request Apr 10, 2024
Open
rhnasc pushed a commit to inloco/loki that referenced this pull request Apr 12, 2024
@slim-bean @trevorwhitney
@DylanGuedes @JStickler @rhnasc
feat!: update helm chart to support distributed mode and 3.0 (grafana…
183508c 
…#12067)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
This was referenced Apr 17, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Apr 29, 2024
Closed
@anindyameister anindyameister mentioned this pull request May 1, 2024
Closed
This was referenced May 6, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request May 20, 2024
Closed
This was referenced May 27, 2024
Closed
Closed
This was referenced Jun 10, 2024
Closed
Merged
@messiahUA
Copy link

May I ask why the simple scalable check was removed from the helm chart for "loki.querySchedulerAddress" ?

@loki-gh-app loki-gh-app bot mentioned this pull request Jun 24, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 1, 2024
Closed
@grafanabot grafanabot mentioned this pull request Jul 2, 2024
Closed
This was referenced Jul 3, 2024
Closed
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 15, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
@slim-bean @trevorwhitney
@DylanGuedes @JStickler
feat!: update helm chart to support distributed mode and 3.0 (grafana…
bbc7a9a 
…#12067)

Signed-off-by: Edward Welch <edward.welch@grafana.com>
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
Co-authored-by: Dylan Guedes <djmgguedes@gmail.com>
Co-authored-by: J Stickler <julie.stickler@grafana.com>
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 18, 2024
Closed
lindeskar
lindeskar reviewed Feb 17, 2025
View reviewed changes
production/helm/loki/values.yaml
querier: {}
# -- Optional ingester configuration
ingester: {}
# -- Optional index gateway configuration
index_gateway:
mode: ring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I'm curious to the reason behind this change. Is ring mode not recommended for Index Gateway? Please help me understand. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoyosir yoyosir yoyosir left review comments

@JStickler JStickler JStickler left review comments

@lindeskar lindeskar lindeskar left review comments

@trevorwhitney trevorwhitney trevorwhitney approved these changes

Assignees
No one assigned
Labels
area/helm backport release-3.0.x product-approved size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@slim-bean @messiahUA @trevorwhitney @yoyosir @JStickler @lindeskar @DylanGuedes