Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query range step does not support duration string. #1209

Closed
cyriltovena opened this issue Oct 29, 2019 · 1 comment · Fixed by #1355
Closed

Query range step does not support duration string. #1209

cyriltovena opened this issue Oct 29, 2019 · 1 comment · Fixed by #1355
Assignees
@nehayward
Labels
component/loki good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! keepalive An issue or PR that will be kept alive and never marked as stale.

Comments

@cyriltovena
Copy link
Contributor

From slack:

prometheus seems to accept a "step" parameter as either a duration string or float, but loki seems to >only accept integers representing seconds - are there plans for loki's API to be brought more in line with >Prometheus' API in this respect?

Easy change to support and we should be as close as possible to Prometheus.

Please also update the doc.
@cyriltovena cyriltovena added component/loki component/docs help wanted We would love help on these issues. Please come help us! good first issue These are great first issues. If you are looking for a place to start, start here! keepalive An issue or PR that will be kept alive and never marked as stale. labels Oct 29, 2019
@nehayward
Copy link

I can give this a try

@nehayward nehayward mentioned this issue Oct 29, 2019
Closed
2 tasks
@cyriltovena cyriltovena mentioned this issue Nov 29, 2019
Closed
@danieldabate danieldabate mentioned this issue Dec 3, 2019
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nehayward nehayward

Labels
component/loki good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! keepalive An issue or PR that will be kept alive and never marked as stale.
Projects
None yet
Milestone
No milestone
2 participants
@cyriltovena @nehayward