Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Tail url looks incorrect #12586

Closed
slim-bean opened this issue Apr 11, 2024 · 0 comments · Fixed by #13297
Closed

Helm: Tail url looks incorrect #12586

slim-bean opened this issue Apr 11, 2024 · 0 comments · Fixed by #13297

Comments

@slim-bean
Copy link
Collaborator

          not sure if this is intended but in the [_helpers.tpl](https://github.com/grafana/loki/blob/main/production/helm/loki/templates/_helpers.tpl#L955C8-L955C39) there is an if check which might be wrong: 
{{- if "loki.deployment.isDistributed "}}

similar check is done here which looks like this:

{{- $isDistributed := eq (include "loki.deployment.isDistributed" .) "true" -}}
{{- if $isDistributed -}}

This causes the if check to always be true and thus the frontend.tail_proxy_url to be set in the loki config. But the configured tail_proxy_url does not point to an existing service (I used SSD deplyoment mode). Not sure if this has any impact.

Originally posted by @dakr0013 in #12506 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants