-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: promtail race fixes #12656
fix: promtail race fixes #12656
Conversation
Before the changes, the Go data race detector found many issues. After these changes, test results were clean:
|
// Create a channel for log messages | ||
logCh := make(chan string, 100) // Buffered channel to avoid blocking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was the logging change required for fixing a test race here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a race related to the t
essentially. The t.Logf("received request: %s", counts)
was in a goroutine and was fighting with t.Logf("started test server at URL %s", testServer.URL)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome @paul1r thanks!
What this PR does / why we need it:
Multiple data race fixes for promtail code
Which issue(s) this PR fixes:
Relates to #8586
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR