Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: TSDB: Add fast-path to inversePostingsForMatcher #12679

Merged
merged 1 commit into from
Apr 19, 2024

Conversation

DylanGuedes
Copy link
Contributor

What this PR does / why we need it:
Our inversePostingsForMatcher code was introduced ~2 years ago. Since then, Prometheus added some nice performance optimizations that we didn't track (example).
This PR updates our inversePostingsForMatcher implementation to inherit two of them, that are fast-paths and allow skipping a LabelValues query.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@DylanGuedes DylanGuedes requested a review from a team as a code owner April 18, 2024 17:00
@DylanGuedes DylanGuedes changed the title performance: TSDB: Add fast-path to inversePostingsForMatcher perf: TSDB: Add fast-path to inversePostingsForMatcher Apr 18, 2024
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena cyriltovena merged commit 402d1d7 into main Apr 19, 2024
15 checks passed
@cyriltovena cyriltovena deleted the update-inversepostingsformatcher branch April 19, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants