-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a version of the mixin dashboards for meta monitoring #12700
Conversation
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: why put these in the loki
repo rather than have them live in the meta-monitoring repo?
Mainly because the code was here already and because it's nice to have the base set of files in 1 place. But it can be moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving to unblock, but I'm against this strategy long term. this is now the 3rd compiled version of the mixin we'll have in loki which I think goes against the spirit of having these defined in dynamic, configurable jsonnet recipes.
I still like the idea of doing the actual jsonnet compilation in a k8s job deployed by the helm chart. that would allow lots of customization via the values file. wdyt?
Signed-off-by: Michel Hollands <michel.hollands@gmail.com>
…to add_combined_mixin_state
Thanks. I've updated this PR so it doesn't generate the new version here. That will now be done in the meta-monitoring-chart repo in this PR. That is then a base to move it to a k8s job. |
What this PR does / why we need it:
This builds dashboards for the meta monitoring charts based on the mixin dashboards. These are stored in a new directory under production.
The job labels are changed so they can work with all 3 modes (single binary, SSD and micro services. So instead of
this is used:
Something similar is done for pod selectors, which are used in some dashboards.
A fix was also made for the deletion dashboard in SSD mode. This still assumed the compactor was running in the read pods instead of the backend pods.
As this isn't easy to test further changes will be made in separate PRs after this has been installed in a few places.
Checklist
CONTRIBUTING.md
guide (required)docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR