Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add metrics for number of patterns detected & evicted #12918

Merged
merged 4 commits into from
May 15, 2024

Conversation

benclive
Copy link
Contributor

@benclive benclive commented May 8, 2024

What this PR does / why we need it:
Adds two metrics for tracking the operation of the Patterns extraction.

  • One to count whenever we find a new pattern ("LogCluster")
  • One to count whenever a pattern is evicted from the LRU cache (I believe this only happens if a single stream has more than 300 patterns)

Together, they should let us understand the performance & memory use of the pattern-ingester in order to know whether to tweak the number of patterns generated or to prune more often.

@benclive benclive requested a review from a team as a code owner May 8, 2024 14:00
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cyriltovena
Copy link
Contributor

Need a conflict resolution before merging.

@cyriltovena cyriltovena enabled auto-merge (squash) May 13, 2024 13:36
@benclive benclive force-pushed the add-pattern-detection-metrics branch from 82aebc1 to abe127b Compare May 15, 2024 09:40
@pull-request-size pull-request-size bot added size/L and removed size/M labels May 15, 2024
@cyriltovena cyriltovena merged commit bc53b33 into main May 15, 2024
59 checks passed
@cyriltovena cyriltovena deleted the add-pattern-detection-metrics branch May 15, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants