fix(otel): Map 500 errors to 503 #13173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7875c28.
chaudum
reviewed
Jun 7, 2024
pkg/distributor/http.go
Outdated
Comment on lines
35
to
40
| func (i *OtelErrorHeaderInterceptor) WriteHeader(statusCode int) { | ||
| if statusCode == http.StatusInternalServerError { | ||
| i.ResponseWriter.WriteHeader(http.StatusServiceUnavailable) | ||
| } else { | ||
| i.ResponseWriter.WriteHeader(statusCode) | ||
| } |
There was a problem hiding this comment.
Can you add a comment why we are doing this, e.g. link the OTLP spec https://opentelemetry.io/docs/specs/otlp/#failures-1
chaudum
approved these changes
Jun 7, 2024
grobinson-grafana
approved these changes
Jun 7, 2024
grafanabot
pushed a commit
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit b31e04e)
7 tasks
grafanabot
pushed a commit
that referenced
this pull request
Jun 7, 2024
(cherry picked from commit b31e04e)
7 tasks
This was referenced Jun 10, 2024
This was referenced Jul 3, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR