Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(blooms): Suppress error from resolving server addresses for blocks #13385

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Jul 2, 2024

What this PR does / why we need it:

Instead of returning the error, FilterChunks returns the full, unfiltered list of chunks.

This makes sure that queries do not fail if no bloom gateway instances are available.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum chaudum requested a review from a team as a code owner July 2, 2024 16:53
if err != nil {
return nil, errors.Wrapf(err, "server address for block: %s", blockWithSeries.block)
level.Error(c.logger).Log("msg", "failed to resolve server address for block", "block", blockWithSeries.block, "err", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think resolving a single address should necessarily fail all addresses, but gracefully degrading the whole request is a fair place to start.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one possible ways how this can fail, because there is only one case Addr() returns an error, and this is because there are no servers available.
Therefore subsequent calls of Addr() are very likely to fail as well.

Instead of returning the error, `FilterChunks` returns the full,
unfiltered list of chunks.

This makes sure that queries do not fail if no bloom gateway instances
are available.

Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum force-pushed the chaudum/suppress-bloom-gateway-client-error branch from 98c7a37 to b101b28 Compare July 3, 2024 06:33
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum merged commit 3ac2317 into main Jul 3, 2024
60 checks passed
@chaudum chaudum deleted the chaudum/suppress-bloom-gateway-client-error branch July 3, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants