Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mixins): merge resources dashboards for ssd into one #13471

Conversation

QuentinBisson
Copy link
Contributor

What this PR does / why we need it:

Single Scalable deployment mixins were not showing the full resource usage as the backend pods were ignored.

This PR merges the existing read-resources and write resources dashboard into 1 for SSD and adds the backend resources. The idea was already communicated in with @cstyan in this PR #13023

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@QuentinBisson QuentinBisson requested a review from a team as a code owner July 10, 2024 11:36
@QuentinBisson QuentinBisson force-pushed the mixins-add-resource-overview-dashboard-for-ssd branch from aba5b93 to 1f3afb0 Compare July 10, 2024 11:42
@QuentinBisson QuentinBisson changed the title enhancement(mixins): merge resources dashboards for ssd into one feat(mixins): merge resources dashboards for ssd into one Jul 10, 2024
@QuentinBisson
Copy link
Contributor Author

@cstyan or @MichelHollands I would love some inputs if you have the time of course

@cstyan
Copy link
Contributor

cstyan commented Jul 12, 2024

@QuentinBisson am I understanding correctly, this should supersede your other PR #13023 ?

@QuentinBisson
Copy link
Contributor Author

Yes and no 😅 because thé other PR also include the addition of a backend path in the Loki opérational dashboard so I will rename it later on :)

@cstyan
Copy link
Contributor

cstyan commented Sep 17, 2024

@QuentinBisson need to merge in again after some of the other PRs have been merged

…w dashboard

Signed-off-by: QuentinBisson <quentin@giantswarm.io>
@QuentinBisson QuentinBisson force-pushed the mixins-add-resource-overview-dashboard-for-ssd branch from 0394cc0 to 105894f Compare September 18, 2024 13:53
@QuentinBisson
Copy link
Contributor Author

Should be good @cstyan :)

@cstyan cstyan merged commit 45b8719 into grafana:main Sep 18, 2024
61 checks passed
@QuentinBisson
Copy link
Contributor Author

Hey @cstyan I regened the mixins on my hand but I have some weird layout on this one
image

I think I need to play with gridpos but I'm not sure how to do it so if you have some insight that would be awesome :)

@QuentinBisson
Copy link
Contributor Author

Fix here #14178 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants