-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mixins): merge resources dashboards for ssd into one #13471
feat(mixins): merge resources dashboards for ssd into one #13471
Conversation
aba5b93
to
1f3afb0
Compare
@cstyan or @MichelHollands I would love some inputs if you have the time of course |
@QuentinBisson am I understanding correctly, this should supersede your other PR #13023 ? |
Yes and no 😅 because thé other PR also include the addition of a backend path in the Loki opérational dashboard so I will rename it later on :) |
@QuentinBisson need to merge in again after some of the other PRs have been merged |
…w dashboard Signed-off-by: QuentinBisson <quentin@giantswarm.io>
0394cc0
to
105894f
Compare
Should be good @cstyan :) |
Hey @cstyan I regened the mixins on my hand but I have some weird layout on this one I think I need to play with |
Fix here #14178 😄 |
What this PR does / why we need it:
Single Scalable deployment mixins were not showing the full resource usage as the backend pods were ignored.
This PR merges the existing read-resources and write resources dashboard into 1 for SSD and adds the backend resources. The idea was already communicated in with @cstyan in this PR #13023
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR