Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Retain original values in logfmt pattern tokenizer #13535

Merged
merged 2 commits into from
Jul 17, 2024
Merged

fix: Retain original values in logfmt pattern tokenizer #13535

merged 2 commits into from
Jul 17, 2024

Conversation

benclive
Copy link
Contributor

What this PR does / why we need it:

  • logfmt tokenizer treats some strings as special, "null" being one of them - its gets serialised as "null" instead of just null.
  • By passing the tokens are bytes, the encoder doesn't do any special processing to them.
  • Used the existing unsafe conversion func to avoid more allocations.

Which issue(s) this PR fixes:
Fixes #13476

@benclive benclive requested a review from a team as a code owner July 16, 2024 09:58
@benclive benclive requested a review from cyriltovena July 16, 2024 09:58
cyriltovena
cyriltovena approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benclive benclive merged commit 5fa9c4b into main Jul 17, 2024
61 checks passed
@benclive benclive deleted the benclive/retain-original-log-line-in-logfmt-tokenizer branch July 17, 2024 13:15
@loki-gh-app loki-gh-app bot mentioned this pull request Jul 22, 2024
Closed
This was referenced Aug 15, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Closed
This was referenced Oct 14, 2024
Closed
Closed
This was referenced Oct 21, 2024
Closed
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 4, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Nov 11, 2024
Closed
@loki-gh-app loki-gh-app bot mentioned this pull request Dec 4, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Dec 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyriltovena cyriltovena cyriltovena approved these changes

Assignees
No one assigned
Labels
size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: quotes being added to patterns in pattern ingester when not present in original log line
2 participants
@benclive @cyriltovena